Skip to content

Onboard: FDA food dataset#223

Merged
adlersantos merged 7 commits intoGoogleCloudPlatform:mainfrom
nlarge-google:fda_food
Dec 8, 2021
Merged

Onboard: FDA food dataset#223
adlersantos merged 7 commits intoGoogleCloudPlatform:mainfrom
nlarge-google:fda_food

Conversation

@nlarge-google
Copy link
Copy Markdown
Contributor

@nlarge-google nlarge-google commented Nov 3, 2021

Description

Includes:
fda_food.food_enforcement,
fda_food.food_events

Checklist

Note: Delete items below that aren't applicable to your pull request.

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/fda_food and nothing outside of that directory.
  • This PR is appropriately labeled.

@google-cla google-cla Bot added the cla: yes label Nov 3, 2021
@nlarge-google
Copy link
Copy Markdown
Contributor Author

@adlersantos Please review this codse at your earliest convenience. Thanks!

Copy link
Copy Markdown
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR uses too many images. Try reducing them, or using a single one for pipelines and transforms that have much in common.

@nlarge-google
Copy link
Copy Markdown
Contributor Author

@adlersantos I have merged FDA into one dataset. Please review. Thanks!

Copy link
Copy Markdown
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@adlersantos adlersantos merged commit f0ced96 into GoogleCloudPlatform:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants