fix(backup): backup name regex (#970)

AmitMatsil · web-flow · commit 6ef122ad49f4 · 2024-05-29T16:55:18.000-07:00
Change the regular expression to match the format specified in the Bigtable Admin API documentation: https://cloud.google.com/bigtable/docs/reference/admin/rest/v2/projects.instances.clusters.backups/create
diff --git a/google/cloud/bigtable/backup.py b/google/cloud/bigtable/backup.py
@@ -28,7 +28,7 @@
     r"^projects/(?P<project>[^/]+)/"
     r"instances/(?P<instance_id>[a-z][-a-z0-9]*)/"
     r"clusters/(?P<cluster_id>[a-z][-a-z0-9]*)/"
-    r"backups/(?P<backup_id>[a-z][a-z0-9_\-]*[a-z0-9])$"
+    r"backups/(?P<backup_id>[_a-zA-Z0-9][-_.a-zA-Z0-9]*)$"
 )
 
 _TABLE_NAME_RE = re.compile(

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@`
`28`	`28`	`r"^projects/(?P<project>[^/]+)/"`
`29`	`29`	`r"instances/(?P<instance_id>[a-z][-a-z0-9]*)/"`
`30`	`30`	`r"clusters/(?P<cluster_id>[a-z][-a-z0-9]*)/"`
`31`		`- r"backups/(?P<backup_id>[a-z][a-z0-9_\-]*[a-z0-9])$"`
	`31`	`+ r"backups/(?P<backup_id>[_a-zA-Z0-9][-_.a-zA-Z0-9]*)$"`
`32`	`32`	`)`
`33`	`33`
`34`	`34`	`_TABLE_NAME_RE = re.compile(`