fix: destroy pipeline streams when returned stream errors (#2437)

ddelgrosso1 · gcf-owl-bot[bot] · web-flow · commit fe1ac655a8d3 · 2024-04-15T09:23:39.000-04:00
* fix: destroy pipeline streams when returned stream errors * handle close on writeStream * use once * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
diff --git a/src/file.ts b/src/file.ts
@@ -2035,6 +2035,16 @@ class File extends ServiceObject<File, FileMetadata> {
         emitStream.write(chunk, encoding, cb);
       },
     });
+    // If the write stream, which is returned to the caller, catches an error we need to make sure that
+    // at least one of the streams in the pipeline below gets notified so that they
+    // all get cleaned up / destroyed.
+    writeStream.once('error', e => {
+      emitStream.destroy(e);
+    });
+    // If the write stream is closed, cleanup the pipeline below by calling destroy on one of the streams.
+    writeStream.once('close', () => {
+      emitStream.destroy();
+    });
 
     const transformStreams: Transform[] = [];
 
