fix(storage): modify the callback of mrd to return length of data read instead of limit.#11687
Merged
gcf-merge-on-green[bot] merged 7 commits intogoogleapis:mainfrom Mar 6, 2025
Conversation
tritone
approved these changes
Mar 5, 2025
BrennaEpp
reviewed
Mar 6, 2025
This was referenced Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently MRD takes a callback in each Add call.
Current call back returns the offset, length and error on that add call making the callback function look like, func(int64,int64,error) .
In some scenario data read can be different from limit set.
For example: We just have 50 bytes to read and ask for 100 bytes(length/limit) in this scenario we will return just 50 bytes.
Hence changed the callback to return amount of data read instead of data limit set.
Added the go doc for callback.