fix(storage): Skip only specific transport tests. (#11016)

cjc25 · tritone · web-flow · commit d40fbff9c198 · 2024-10-23T14:07:12.000-04:00
Some client tests only work with certain transports, so we try to skip
them. However by calling `t.Skip()` before the per-transport `t.Run()`,
we skipped every remaining sub-test once we hit that condition.

This changes the code to skip only the relevant transport, by skipping
the testing.T for the sub-test.

Co-authored-by: Chris Cotter &lt;cjcotter@google.com&gt;
diff --git a/storage/client_test.go b/storage/client_test.go
@@ -1584,10 +1584,10 @@ func transportClientTest(ctx context.Context, t *testing.T, test func(*testing.T
 	checkEmulatorEnvironment(t)
 
 	for transport, client := range emulatorClients {
-		if reason := ctx.Value(skipTransportTestKey(transport)); reason != nil {
-			t.Skip("transport", fmt.Sprintf("%q", transport), "explicitly skipped:", reason)
-		}
 		t.Run(transport, func(t *testing.T) {
+			if reason := ctx.Value(skipTransportTestKey(transport)); reason != nil {
+				t.Skip("transport", fmt.Sprintf("%q", transport), "explicitly skipped:", reason)
+			}
 			project := fmt.Sprintf("%s-project", transport)
 			bucket := fmt.Sprintf("%s-bucket-%d", transport, time.Now().Nanosecond())
 			test(t, ctx, project, bucket, client)
