feat(bigtable): Update ListSchemaBundles to returns only names (#12563)

ron-gal · web-flow · commit 83ea7c420baf · 2025-07-15T10:02:09.000-07:00
* feat(bigtable): Update ListSchemaBundles to returns only names

* fix format
diff --git a/bigtable/admin.go b/bigtable/admin.go
@@ -3515,8 +3515,8 @@ func (ac *AdminClient) GetSchemaBundle(ctx context.Context, tableID, schemaBundl
 }
 
 // SchemaBundles returns a list of the schema bundles in the table.
-func (ac *AdminClient) SchemaBundles(ctx context.Context, tableID string) ([]SchemaBundleInfo, error) {
-	bundles := []SchemaBundleInfo{}
+func (ac *AdminClient) SchemaBundles(ctx context.Context, tableID string) ([]string, error) {
+	names := []string{}
 	prefix := fmt.Sprintf("%s/tables/%s", ac.instancePrefix(), tableID)
 
 	req := &btapb.ListSchemaBundlesRequest{
@@ -3533,17 +3533,9 @@ func (ac *AdminClient) SchemaBundles(ctx context.Context, tableID string) ([]Sch
 	}
 
 	for _, res := range res.SchemaBundles {
-		sb := SchemaBundleInfo{
-			TableID:        tableID,
-			SchemaBundleID: strings.TrimPrefix(res.Name, prefix+"/schemaBundles/"),
-			Etag:           res.Etag,
-		}
-		if len(res.GetProtoSchema().GetProtoDescriptors()) > 0 {
-			sb.SchemaBundle = res.GetProtoSchema().GetProtoDescriptors()
-		}
-		bundles = append(bundles, sb)
+		names = append(names, strings.TrimPrefix(res.Name, prefix+"/schemaBundles/"))
 	}
-	return bundles, nil
+	return names, nil
 }
 
 // UpdateSchemaBundleConf contains all the information necessary to update or partial update a schema bundle.
diff --git a/bigtable/integration_test.go b/bigtable/integration_test.go
@@ -4992,12 +4992,9 @@ func TestIntegration_AdminSchemaBundle(t *testing.T) {
 	if got, want := len(schemaBundles), 1; got != want {
 		t.Fatalf("Listing schema bundles count: %d, want: != %d", got, want)
 	}
-	if got, want := schemaBundles[0].SchemaBundleID, schemaBundle; got != want {
+	if got, want := schemaBundles[0], schemaBundle; got != want {
 		t.Errorf("SchemaBundle Name: %s, want: %s", got, want)
 	}
-	if got, want := schemaBundles[0].SchemaBundle, content; !reflect.DeepEqual(got, want) {
-		t.Errorf("ProtoSchema: %v, want: %v", got, want)
-	}
 
 	// Get schema bundle
 	sbInfo, err := adminClient.GetSchemaBundle(ctx, tblConf.TableID, schemaBundle)

Original file line number	Diff line number	Diff line change
`@@ -4992,12 +4992,9 @@ func TestIntegration_AdminSchemaBundle(t *testing.T) {`
`4992`	`4992`	`if got, want := len(schemaBundles), 1; got != want {`
`4993`	`4993`	`t.Fatalf("Listing schema bundles count: %d, want: != %d", got, want)`
`4994`	`4994`	`}`
`4995`		`- if got, want := schemaBundles[0].SchemaBundleID, schemaBundle; got != want {`
	`4995`	`+ if got, want := schemaBundles[0], schemaBundle; got != want {`
`4996`	`4996`	`t.Errorf("SchemaBundle Name: %s, want: %s", got, want)`
`4997`	`4997`	`}`
`4998`		`- if got, want := schemaBundles[0].SchemaBundle, content; !reflect.DeepEqual(got, want) {`
`4999`		`- t.Errorf("ProtoSchema: %v, want: %v", got, want)`
`5000`		`- }`
`5001`	`4998`
`5002`	`4999`	`// Get schema bundle`
`5003`	`5000`	`sbInfo, err := adminClient.GetSchemaBundle(ctx, tblConf.TableID, schemaBundle)`