fix(storage): Update offset on resumable upload retry (#12086)

cjc25 · web-flow · commit 6ce8fe5aec0e · 2025-05-01T02:16:21.000Z
When resumable uploads retry, they may observe a flush offset which is past the start of the current send (in fact the whole send might have already completed). In that case, we avoided re-sending unnecessary data, but we didn't update the offset to account for the data not sent.
diff --git a/storage/grpc_writer.go b/storage/grpc_writer.go
@@ -464,6 +464,7 @@ func (s *gRPCResumableBidiWriteBufferSender) sendBuffer(ctx context.Context, buf
 			trim = int64(len(buf))
 		}
 		buf = buf[trim:]
+		offset += trim
 	}
 	if len(buf) == 0 && !flush && !finishWrite {
 		// no need to send anything

Original file line number	Diff line number	Diff line change
`@@ -464,6 +464,7 @@ func (s *gRPCResumableBidiWriteBufferSender) sendBuffer(ctx context.Context, buf`
`464`	`464`	`trim = int64(len(buf))`
`465`	`465`	`}`
`466`	`466`	`buf = buf[trim:]`
	`467`	`+ offset += trim`
`467`	`468`	`}`
`468`	`469`	`if len(buf) == 0 && !flush && !finishWrite {`
`469`	`470`	`// no need to send anything`