fix(storage): more strongly match regex (#9706)

codyoss · web-flow · commit 3cfc8eb418e0 · 2024-04-04T16:02:18.000Z
Fixes: #9705
diff --git a/storage/notifications.go b/storage/notifications.go
@@ -116,7 +116,7 @@ func toProtoNotification(n *Notification) *storagepb.NotificationConfig {
 	}
 }
 
-var topicRE = regexp.MustCompile("^//pubsub.googleapis.com/projects/([^/]+)/topics/([^/]+)")
+var topicRE = regexp.MustCompile(`^//pubsub\.googleapis\.com/projects/([^/]+)/topics/([^/]+)`)
 
 // parseNotificationTopic extracts the project and topic IDs from from the full
 // resource name returned by the service. If the name is malformed, it returns

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ func toProtoNotification(n Notification) storagepb.NotificationConfig {`
`116`	`116`	`}`
`117`	`117`	`}`
`118`	`118`
`119`		`-var topicRE = regexp.MustCompile("^//pubsub.googleapis.com/projects/([^/]+)/topics/([^/]+)")`
	`119`	+var topicRE = regexp.MustCompile(`^//pubsub\.googleapis\.com/projects/([^/]+)/topics/([^/]+)`)
`120`	`120`
`121`	`121`	`// parseNotificationTopic extracts the project and topic IDs from from the full`
`122`	`122`	`// resource name returned by the service. If the name is malformed, it returns`